Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for VK_EXT_depth_clip_control #2430

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add support for VK_EXT_depth_clip_control #2430

merged 1 commit into from
Jan 29, 2025
+27 −0

Conversation

squidbus
Copy link
Contributor

SPIRV-Cross already has a flag for converting from [-w, w] depth to [0, w]. Take advantage of that to implement VK_EXT_depth_clip_control.

Ran CTS tests dEQP-VK.pipeline.monolithic.depth.depth_clip_control.*, results:

Test run totals:
  Passed:        36/72 (50.0%)
  Failed:        0/72 (0.0%)
  Not supported: 36/72 (50.0%)
  Warnings:      0/72 (0.0%)
  Waived:        0/72 (0.0%)

With the general case for Not supported just being tests using unsupported depth formats.

cdavis5e
cdavis5e approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is straightforward enough.

@cdavis5e cdavis5e merged commit aba9976 into KhronosGroup:main Jan 29, 2025
6 checks passed
@makigumo
Copy link

Shouldn't shouldFixupClipSpace also be added here?

MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKPipeline.mm

Lines 2725 to 2733 in aba9976

template<class Archive>
void serialize(Archive & archive, SPIRVToMSLConversionOptions& opt) {
archive(opt.mslOptions,
opt.entryPointName,
opt.entryPointStage,
opt.tessPatchKind,
opt.numTessControlPoints,
opt.shouldFlipVertexY);
}

@squidbus squidbus mentioned this pull request Jan 29, 2025
Merged
@squidbus
Copy link
Contributor Author

You are right, I seem to have missed that. I've opened a fix for that here #2432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavis5e cdavis5e cdavis5e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squidbus @makigumo @cdavis5e